-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More comprehensive JaCoCo support #1120
Conversation
…line covered or missed numbers.
…e switch is on then the CodeCoverage parameters of the Describe parts will be used for code coverage.
Any idea why "Publish Status to GitHub (Pester)" check has failed? |
@Thilas the error says: "The process cannot access the file |
@nohwnd, thank you for the feedback. I've just figured out how to get the error myself (logging in as a guest). What's even stranger here is that it fails only on PowerShell v2, version on which code coverage doesn't apply (and I didn't change a thing on this part). I don't see any new build here. I guess you didn't run a new one yet? Otherwise, any thought about the PR? |
@nohwnd, any news about this? |
@Thilas the tests keep failing with the same error, it's likely a problem with the build server, because it's not only this build that fails. Unfortunately I have no power over the build server. @dlwyatt could you help please? It's the same problem as before. A file is locked and makes the tests fail. |
@dlwyatt, any news about this? Thanks. |
@nohwnd, tests are now passing. What's next? Some reviews I guess? Thanks for your help. |
@Thilas I will review it and let you know :) Thanks for you patience. |
@Thilas I merged #920 into master, and master into your changes, if it builds I will merge it in master. There were few merge conflicts but it should be all good now. Please give it a quick look if you have time. Also could you share on which build server you use this? And possibly test it there again before I merge? It definitely has to work on Azure pipelines. |
Merged thanks! |
Thanks @nohwnd. You already merged the branch, but I'll try this anyway to provide the feebacks you wanted. |
@Thilas yes that would be great. I plan to release in few days. Thank you. |
My tests are ok. Let's release it! |
Following work done on #920, here are some changes that bring a more comprehensive support of JaCoCo format.
Basically, it now fully supports JaCoCo format (updated to 1.1):
class
elements for each script filemethod
elements for each method in a script file (as well as ascript()
method for code with no method)sourcefilename
attributes to link coverage with source codecounter
elements wherever it is possible toAll this allows to generate cool reports like the ones created with ReportGenerator thanks to the (very) recent support of JaCoCo.
Also, to minimize changes with current Pester's behavior, I removed the
-DetailedCodeCoverage
parameter added in #920 and the current coverage report is back in the console.And of course, unit tests have been adjusted to check the new xml generated.
Let me know if you have any question. Thanks!