Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"should write the test-suite information" breaks on german machine. Probably an issue with culture awareness. #109

Closed
pullrich opened this issue Feb 12, 2014 · 4 comments

Comments

@pullrich
Copy link
Contributor

Pester\Functions\TestResults.Tests.ps1
Write nunit test results
[-] should write the test-suite information 68ms
Expected: {2.1}, But was {2,1}

There seems to be an issue with culture awareness. This test breaks on a german Windows machine because the german Windows default for decimal sign is comma (",") and the sign for decimal grouping is dot (".").
Changing the Windows defaults accordingly makes this test pass - after restarting PowerShell.

@nohwnd
Copy link
Member

nohwnd commented Feb 12, 2014

Same for me on czech. Already have fix to make the test pass. Can you confirm that the time in the wrong format is output also to the nUnit report? Because I couldn't find it there, but I probably just overlooked it.

@pullrich
Copy link
Contributor Author

Currently I have no idea where to look or what to do for that. Do I have to install nUnit for that?

@nohwnd
Copy link
Member

nohwnd commented Feb 13, 2014

@pullrich re-tested that for you. When you use Invoke-Pester -OutputXML Report.xml, you get nUnit report generated. The report is created by theWrite-NunitTestReport function, and currently I can see it used only in the Invoke-Pester function. When I create a test that is 3.5 seconds long and look in the report I still see that all the Time attributes are set to 0. That was unexpected but I don't see anyone complaining about it. I also asked about it on the Google discussion group

The test that fails is not using Invoke-Pester to create its output. It is creating the data for the XML itself, producing different output than the Invoke-Pester does. Because the time is not output to the nUnit report only the test is now broken. But let's fix this anyway. If the "time" is ever output to the report, it should be culture agnostic.

@nohwnd
Copy link
Member

nohwnd commented Feb 20, 2014

PR #111 merged. Should be fixed.

@nohwnd nohwnd closed this as completed Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants