Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: single crate dependency #7

Closed
tomtau opened this issue Jun 3, 2024 · 2 comments · Fixed by #16
Closed

Refactor: single crate dependency #7

tomtau opened this issue Jun 3, 2024 · 2 comments · Fixed by #16
Labels
help wanted Extra attention is needed

Comments

@tomtau
Copy link
Contributor

tomtau commented Jun 3, 2024

move the current pest3's stuff to pest3_core and make the other pest3_* crates depend on pest3_core; and let pest3 re-export pest3_core and pest3_derive
@tomtau tomtau moved this to Todo in pest3 near-term Jun 3, 2024
@tomtau tomtau added the help wanted Extra attention is needed label Jun 3, 2024
@tomtau tomtau linked a pull request Aug 6, 2024 that will close this issue
move basic types to pest3_core #16
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in pest3 near-term Oct 18, 2024
@tomtau
Copy link
Contributor Author

tomtau commented Oct 18, 2024

#16 (comment)

@tomtau tomtau reopened this Oct 18, 2024
@Tartasprint Tartasprint mentioned this issue Oct 18, 2024
Merged
@Tartasprint
Copy link
Contributor

Can this one be closed ? Or is there more to do ?

@tomtau tomtau closed this as completed Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
pest3 near-term
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move basic types to pest3_core TheVeryDarkness/pest3
2 participants
@tomtau @Tartasprint