-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globalredirect #7
Comments
Hello Paul, I've investigated the issue. And the problem seems to come from the deslash setting which is enabled by default. Here's the commit with a discussion on that. I've created a tiny Drupal 6 module that fixes the issue if you prefer not to deal with the hassle of checking the settings form. Try it out and please report back. Thanks, |
Hello perusio, Thanks for answering to my previous issues. I noticed that Global Redirect (and coder review) 7.x counts on "custom_url_rewrite_outbound" which means drupal_spaces.conf to be used. Would be nice if you could revise "Configuration Selection Algorithm" accordingly. |
Global Redirect doesn't use it. Just invokes the function if it exists. But that is incorrect |
I think this is fixed. Re-open if issue resurfaces. |
perusio, sorry for not updating you. You are right, global redirect looks for an abandoned function. The code I mean is here,
// TODO: This looks wrong for D7... maybe a hook?
if (function_exists('custom_url_rewrite_outbound')) {
// Modules may alter outbound links by reference.
custom_url_rewrite_outbound($alias, $options, $current_path);
}
I am experiencing a strange infinite redirect problem when switching from one language to another when global redirect and local enabled. I thought this could be a problem with my nginx configuration. Anyway the site I develop will only have English for now. Thanks for your assistance. |
I've reopened. Could be. Can you show me the logs? Preferably with the Thanks, |
perusio, don't worry the infinite redirect happens in apache as well. This could be an issue with globalredirect module http://drupal.org/node/1145802 |
This is documented and the fix is easy. Just set:
when globalredirect is active. |
Thanks perusio. The drush (or $conf) solution works. Apparently settings that variable manually can be done in language settings: |
https://github.com/perusio/drupal-with-nginx/blob/master/sites-available/drupal.conf#L87 not working with globalredirect. Old variant
rewrite ^/(.*)$ /index.php?q=$1 last;
working great.The text was updated successfully, but these errors were encountered: