Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose onDownloadProgress #282

Closed
wenerme opened this issue Dec 21, 2021 · 3 comments · Fixed by #284
Closed

expose onDownloadProgress #282

wenerme opened this issue Dec 21, 2021 · 3 comments · Fixed by #284

Comments

@wenerme
Copy link
Contributor

wenerme commented Dec 21, 2021

axios support onDownloadProgress, when get large file, this allowed to build a progress bar.
@wenerme
Copy link
Contributor Author

wenerme commented Dec 21, 2021

How about when prepareRequestOptions allowed bypassing all unknown options to axios

@wenerme wenerme mentioned this issue Dec 21, 2021
Closed
@perry-mitchell
Copy link
Owner

allowed bypassing all unknown options to axios

I don't want to pass just any properties to axios, as that makes this library dependent on axios. I may remove axios in the future, so this dependency is something I want to avoid at all costs.

I will accept work that adds download progress, however, so that it could easily be adapted to a potential different library in the future.

@wenerme wenerme mentioned this issue Dec 22, 2021
Merged
@wenerme
Copy link
Contributor Author

wenerme commented Dec 22, 2021

@perry-mitchell understand, changed the pr, also add an signal option in another pr, #285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wenerme @perry-mitchell