Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate variables passed to IlambConfigFile #1

Closed
mdpiper opened this issue Aug 7, 2017 · 2 comments
Closed

Handle duplicate variables passed to IlambConfigFile #1

mdpiper opened this issue Aug 7, 2017 · 2 comments
Assignees
@mdpiper

Comments

@mdpiper
Copy link
Member

mdpiper commented Aug 7, 2017

The IlambConfigFile ctr takes an array_like group of CMIP5 variable short names as required input. For example:

x = IlambConfigFile(['gpp', 'lai', 'le'])

Currently, there's nothing stopping a user from passing duplicate variable names. There should be a check that throws an error when this occurs.
@mdpiper mdpiper self-assigned this Aug 7, 2017
@mdpiper
Copy link
Member Author

mdpiper commented Aug 7, 2017

Could convert input to list, then pop if count is greater than one.

@mdpiper
Copy link
Member Author

mdpiper commented Jan 18, 2018

This is now permamodel/pbs-server#2.

@mdpiper mdpiper closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdpiper mdpiper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdpiper