Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: missing Control.Geocoder.js #310

Open
KristjanESPERANTO opened this issue Nov 28, 2020 · 3 comments
Open

Demo: missing Control.Geocoder.js #310

KristjanESPERANTO opened this issue Nov 28, 2020 · 3 comments
Labels

Comments

@KristjanESPERANTO
Copy link
Contributor

In the file demo/index.html the file ../dist/Control.Geocoder.js is linked, but in the dist directory is no Control.Geocoder.js.

@simon04
Copy link
Collaborator

simon04 commented Nov 28, 2020

The file has to be built first using npm run build

@simon04 simon04 changed the title Missing Control.Geocoder.js Demo: missing Control.Geocoder.js Nov 28, 2020
@KristjanESPERANTO
Copy link
Contributor Author

KristjanESPERANTO commented Nov 28, 2020

Oh, I assumed it would have to be included at least in the release archives. So this issue could be closed.

BTW: Thank you for the new release 🙂

@KristjanESPERANTO
Copy link
Contributor Author

Or would it be an option to change the relative links (css and js) in the demo to unpkg links?

<script src="../dist/Control.Geocoder.js"></script>

=>

<script src="https://unpkg.com/leaflet-control-geocoder/dist/Control.Geocoder.js"></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants