Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Position-agnostic PlacesDetailsPanel component #262

Open
ajolipa opened this issue Mar 7, 2024 · 1 comment
Open

Enhancement: Position-agnostic PlacesDetailsPanel component #262

ajolipa opened this issue Mar 7, 2024 · 1 comment
Assignees
@ajolipa
Labels
enhancement New feature or request

Comments

@ajolipa
Copy link
Contributor

ajolipa commented Mar 7, 2024

It would be useful to have a version of the PlacesDetailsPanel component that can be place more flexibly within pages, e.g. can be used inside a modal, rather than specifically being a sidebar.
@ajolipa ajolipa added the enhancement New feature or request label Mar 7, 2024
@dleadbetter
Copy link
Collaborator

If both components will share similar content (and if possible) it would be nice to have something like:

<Sidebar>
  <PlaceStuff />
</Sidebar>

<Modal>
  <PlaceStuff />
<Modal>

@ajolipa ajolipa linked a pull request Mar 11, 2024 that will close this issue
Update PlacesDetailPanel with more flexible styling #264
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajolipa ajolipa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PlacesDetailPanel with more flexible styling performant-software/react-components
2 participants
@dleadbetter @ajolipa