Added buffer prop to placemarker #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleadbetter
reviewed
Mar 11, 2024
| /** | ||
| * The number of miles to buffer the GeoJSON data. (Defaults to 2.) | ||
| */ | ||
| buffer?: number |
There was a problem hiding this comment.
Let's keep the props in alphabetical order.
dleadbetter
approved these changes
Mar 11, 2024
|
Closing and reopening to get GitHub to recalculate the file differences to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Addresses Issue #259 by adding an optional
bufferprop to thecore-data/PlaceMarkercomponent allowing the user to set the buffer in miles around the GEOJson data. Also adds a new Story showing an example with a 20 mile buffer.