Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handling for null geometry field #265

Closed
wants to merge 10 commits into from
Closed

Added handling for null geometry field #265

wants to merge 10 commits into from

Conversation

ajolipa
Copy link
Contributor

@ajolipa ajolipa commented Mar 9, 2024 •
edited
Loading

In this PR

Improves the error handling of the PlaceMarker component to simply return null rather than throw page-breaking errors when the object fetched from Core Data has no value in the geometry field, addressing Issue #258 .

Notes

For now the simplest seemed to be to just add this case to the check for the existence of overall place data. The behavior seems to be that since the PlaceMarker component returns null, the map simply renders as a world atlas with no place highlighted, which seems like reasonable default behavior to me but obviously could be modified further if desired.

@ajolipa ajolipa requested a review from dleadbetter March 9, 2024 05:40
@ajolipa ajolipa linked an issue Mar 11, 2024 that may be closed by this pull request
Enhancement: Error handling for Place without Geometry #258
Open
@ajolipa ajolipa added the v2.1.0 Issues in v2.1.0 label Mar 11, 2024
dleadbetter
dleadbetter reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@dleadbetter dleadbetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this some more. The actual error is coming from one of the components in the Peripleo dependency. Is this something we should handle in the LocationMarker component instead?

dleadbetter and others added 9 commits March 11, 2024 20:08
RC #261 - Renaming LocationMarker/PlaceMarker components; Adding supp…
f22431e 
…ort for multiple geometries; Adding "core_data" middleware
RC #261 - Adding "jsx" loader to "esbuildOptions" in Storybook vite.c…
cd8b078 
…onfig.js
@dleadbetter
Merge pull request #266 from performant-software/feature/rc261_locati…
941a65b 
…on_markers

RC #261 - Location markers
@ajolipa
updated stories with null geometry example
0bd40f4
@ajolipa
Merge branch 'RB-null-geometry' of https://github.com/performant-soft…
87b1bfc 
…ware/react-components into RB-null-geometry
@ajolipa
delete old placemarker component
ba887db
@ajolipa
delete old placemarker component
c7a11f1
@ajolipa
Merge branch 'RB-null-geometry' of https://github.com/performant-soft…
5d9692b 
…ware/react-components into RB-null-geometry
@ajolipa
updated null geometry story to have new placemarkers component
9c60685
@ajolipa
Copy link
Contributor Author

ajolipa commented Mar 12, 2024

I believe that with the update to the PlaceMarkers component this is no longer an issue; in the current version, the response from Core Data is being fed into the feature or featureColleciton function from turf, which in the case that the geometry data passed in is null will return an empty array of features. This will then fail the new check _.isEmpty(data?.features and thus the component will return null rather than trying to render the LocationMarkers component. If that seems like reasonable/desired behavior, then I think this PR can be closed.

@ajolipa ajolipa mentioned this pull request Mar 16, 2024
Merged
@ajolipa
Copy link
Contributor Author

ajolipa commented Mar 18, 2024

Closing (this is an older version of PR #269 ).

@ajolipa ajolipa closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleadbetter dleadbetter dleadbetter approved these changes

Assignees
No one assigned
Labels
v2.1.0 Issues in v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Error handling for Place without Geometry
2 participants
@ajolipa @dleadbetter