Weird precedence issues between config.yml and ActiveAdmin

[camdendotlol]

On https://umich.covecollective.org/, the "University of Michigan" text in the banner is given the banner_color attribute instead of the site_color attribute, causing it to be indistinguishable from the banner.

This issue is really strange.

• The _umich_brand.html.erb file styles the text with $DOMAIN_CONFIG['site_color'], which is correct.
• The color value stored in the database is correct.
• This issue does not occur on other tenants. See for example https://baylor.covecollective.org/ and https://stthomas.covecollective.org/, where the headers correctly use the site_color property.

Update:

The issue is that the colors are pulled from the config/domain_specific/config.yml file, and the values set in ActiveAdmin are ignored. https://colorado.covecollective.org/ is also affected, where the text color is supposed to be gold but the config file sets it to light gray. I've definitely successfully changed a tenant's colors from ActiveAdmin before, so I'm wondering if there's a precedence thing where whatever is in config.yml takes priority over what's set in ActiveAdmin.

This is a really weird system, and I would propose fixing it by removing the site_color and banner_color lines from config.yml, and making them only updateable via ActiveAdmin. Being able to update the values in the admin interface is by far preferable because it doesn't require code changes or deployments.

[camdendotlol]

@jamiefolsom Dino reported a text color bug in the UMich site and it sent me down this rabbit hole. I could fix the text color in the short term by committing an updated config.yml, but I'd really like to deal with the source of the issue, because having randomly non-functional fields in the admin interface isn't good.