Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't die if out of plan #14

Closed
mitar opened this issue Nov 20, 2018 · 3 comments
Closed

Don't die if out of plan #14

mitar opened this issue Nov 20, 2018 · 3 comments

Comments

@mitar
Copy link

mitar commented Nov 20, 2018

It seems currently Percy integration dies if you run of your plan limits. I would propose that CI should still run, but a warning should be issued, similar to #3.
@Robdel12
Copy link
Contributor

Robdel12 commented Apr 9, 2019 •
edited
Loading

Hey @mitar!

I believe this was fixed with this commit upstream: percy/percy-agent@7e92365

Using the latest version of the SDK, do you sill see this happening?

@mitar
Copy link
Author

mitar commented Apr 9, 2019

Currently I am not our of plan, so cannot test this. :-) But great to see this was fixed. I suggest we close the issue then.

@Robdel12
Copy link
Contributor

Robdel12 commented Apr 9, 2019

Okay cool, if the issue does come up we’ll reopen and get it squashed for you!

@Robdel12 Robdel12 closed this as completed Apr 9, 2019
@pgroot91 pgroot91 mentioned this issue Jul 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitar @Robdel12