-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pxc-db: backup.enabled: false leads to values.yaml overlay not being correctly merged #262
Comments
If you don't need backups to be made on schedule, you can just leave So in your case it would be smth as follows:
|
@spron-in: Thanks for the directions, this was indeed my workaround. However, when I think about your comment, I assume this might be the intended behavior. I mean backup enabled in general without a schedule set, would also make sense for the storage to be set. Shall I leave the issue open or close it? I have two other questions. Maybe you have a quick comment for me on the topic.
|
Hey @cjohn001!
It is an intended behaviour. You can have backups enabled, storage set, schedules NULL. Or you can disable backups completely, this will remove the backup section. We did that to accomodate various developer requests, where backups are not needed at all. As for your questions (btw good ones):
|
Hello @spron-in , |
Hello together.
I am trying to customize the pxc-db chart with a myvalues.yaml. i.e.
helm install pxc-db ./pxc-db -n dev-percona -f cvalues.yaml
I am trying to do some modifications for the backup part
Unfortunately, when setting backup.enabled: false, the entire backup block is not mearged into the resulting yaml.
I would expect that it is merged, because I want to be able to perform manual backups against my s3 storage. This currently seems only to work if I also enable scheduled. backups.
The text was updated successfully, but these errors were encountered: