Add shard label in collstats metrics #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveteuber
requested review from
ademidoff and
JiriCtvrtka
and removed request for
a team
BupycHuk
approved these changes
Nov 1, 2024
|
Tests are failing, could you please take a look? |
steveteuber
force-pushed
the
collstats-shard-label
branch
from
0b97543 to
fda855a
Compare
steveteuber
force-pushed
the
collstats-shard-label
branch
from
fda855a to
da221fb
Compare
|
Now I'm realized that the shards are not ready in the tests... Could you please rerun the tests? |
JiriCtvrtka
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #824. This pull request adds an extra label on all collstats metrics to identify the shard.