chore(ecto_adatper): Update decoding behavior in adapters for Ecto 3.11 #79
Conversation
lib/snowflex/ecto/ecto_adapter.ex
Outdated
| defp int_decode(int) when is_binary(int), do: {:ok, String.to_integer(int)} | ||
| defp int_decode(int), do: {:ok, int} | ||
|
|
||
| defp time_decode(decode), do: {:ok, nil} |
There was a problem hiding this comment.
was it meant nil instead of decode here?
There was a problem hiding this comment.
Yeah, this perplexed me a bit too, even if its not totally necessary, I think if I'm understanding correctly the explicit match would be good here for clarity.
In Ecto 3.11, adapters now handle decoding with nil values, originating from null values in records.
caleb-acosta
force-pushed
the
nil-data-type
branch
from
00a8c04 to
c371d58
Compare
|
We should bump the minimum version of Ecto to at least |
@PM-Pepsico Can updating the minimum Ecto version potentially force projects dependent on this to update their Ecto versions? I don't see these changes requiring an Ecto update, or am I misunderstanding something? |
|
You are correct, I was thinking it would create an issue with older versions. You are definitely right though, this should remain backwards compatible. I'd say go ahead and merge it in. |
This pull request addresses the changes made in Ecto 3.11 regarding decoding behavior in adapters. Previously, decoding in adapters expected a certain type, but with the update to Ecto 3.11, nil values are introduced during the decoding process.
Source: Ecto 3.11 changelog