Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

looper rerun is not only running failed jobs, but everything #467

Closed
nsheff opened this issue Feb 16, 2024 · 1 comment
Closed

looper rerun is not only running failed jobs, but everything #467

nsheff opened this issue Feb 16, 2024 · 1 comment
Assignees
@donaldcampbelljr
Labels
bug likely-solved
Milestone
v1.8.0

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 16, 2024

Like the title says; on a new project with no flags, if I looper rerun, it's running them.

I was expecting it would only run jobs that had failed. the --help says:

Resubmit sample jobs with failed flags.

seems to indicate it wouldn't run if there wasn't a failed flag, so it's broken.
@nsheff nsheff added the bug label Feb 16, 2024
@nsheff nsheff changed the title looper rerun is not only running failed jobs, but everything apparently looper rerun is not only running failed jobs, but everything Feb 16, 2024
@nsheff nsheff added this to the v1.8.0 milestone Feb 16, 2024
donaldcampbelljr added a commit that referenced this issue Mar 13, 2024
@donaldcampbelljr
fix for #467
15a7a9f
@donaldcampbelljr donaldcampbelljr mentioned this issue Mar 13, 2024
Merged
donaldcampbelljr added a commit that referenced this issue Mar 13, 2024
@donaldcampbelljr
Merge pull request #481 from pepkit/dev_fix_467_rerun
c39a7bd 
fix for #467, looper rerun should only rerun failed or waiting jobs
@donaldcampbelljr
Copy link
Contributor

Should be solved with the above PR.

@github-project-automation github-project-automation bot moved this to Done in PEP Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donaldcampbelljr donaldcampbelljr

Labels
bug likely-solved
Projects
No open projects
PEP Vision
Status: Done
Milestone
v1.8.0
Development

No branches or pull requests
2 participants
@nsheff @donaldcampbelljr