Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OutputChunk from #27 instead of analogical csv methods #31

Closed
pepelev opened this issue May 2, 2021 · 2 comments
Closed

Use OutputChunk from #27 instead of analogical csv methods #31

pepelev opened this issue May 2, 2021 · 2 comments
Labels
csv good first issue Good for newcomers
Milestone
PullStream.Csv 2.0.0

Comments

@pepelev
Copy link
Owner

pepelev commented May 2, 2021

No description provided.

@pepelev pepelev added csv good first issue Good for newcomers labels May 2, 2021
@pepelev
Copy link
Owner Author

pepelev commented May 10, 2021

We need to think how to do this with semantic versioning respect

@pepelev
Copy link
Owner Author

pepelev commented May 10, 2021

In according to semantic versioning dependency update is done easily if the code remains the same.
So, on this issue we need to

  • reference PullStream 1.2.0
  • make CsvRow empty and inherit OutputChunk
  • obsolete custom Build methods in CsvStream with redirect to general method from builder extensions (check this not cause problems to users)
  • release it as 1.1.0 because of deprecation

@pepelev pepelev added this to the PullStream.Csv 2.0.0 milestone Jun 14, 2021
@pepelev pepelev closed this as completed Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
csv good first issue Good for newcomers
Projects
None yet
Milestone
PullStream.Csv 2.0.0
Development

No branches or pull requests
1 participant
@pepelev