Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibc: rename ibc_actions proto field for legibiility #3209

Closed
Tracked by #454
conorsch opened this issue Oct 18, 2023 · 1 comment · Fixed by #3284
Closed
Tracked by #454

ibc: rename ibc_actions proto field for legibiility #3209

conorsch opened this issue Oct 18, 2023 · 1 comment · Fixed by #3284

Comments

@conorsch
Copy link
Contributor

conorsch commented Oct 18, 2023 •
edited
Loading

There's currently a field on the TransactionPlannerRequest proto called ibc_actions:

Counterintuitively, this field does not accept an Ics20Withdrawal, but rather applies specifically to actions related to relaying, not transaction planning. Let's rename the field to something like ibc_relay_actions and the corresponding type IbcRelay.

See related discussion in #3108.
@conorsch conorsch moved this to Next in Testnets Oct 18, 2023
@hdevalence
Copy link
Member

Counterintuitively, this field does not accept an Ics20Withdrawal, but rather applies specifically to actions related to relaying, not transaction planning.

It would definitely be more clear if this were called ibc_relay_actions, but it's not the case that this isn't related to transaction planning. Rather, it's for planning transactions that relay IBC packets -- once we have nonzero gas prices, IBC relaying will require planning, so that the transaction can pay fees for the relayed data.

@aubrika aubrika added this to Penumbra Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Oct 30, 2023
@erwanor erwanor mentioned this issue Nov 3, 2023
Merged
@conorsch conorsch mentioned this issue Nov 7, 2023
Closed
32 tasks
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra Nov 13, 2023
@github-project-automation github-project-automation bot moved this from Next to Testnet 63: Rhea (Web Wallet) in Testnets Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Penumbra
Archived in project
Testnets
Status: Testnet 63: Rhea (Web Wallet)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

penumbra-ibc: rename ibc relay actions penumbra-zone/penumbra
2 participants
@hdevalence @conorsch