Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: check for tendermint client update problems #3193

Closed
Tracked by #454
conorsch opened this issue Oct 16, 2023 · 2 comments
Closed
Tracked by #454

ibc: check for tendermint client update problems #3193

conorsch opened this issue Oct 16, 2023 · 2 comments
Assignees
Labels
_P-high High priority
Milestone

Comments

@conorsch
Copy link
Contributor

See upstream issue here: cosmos/ibc-rs#911 We should check whether our impls in the ibc component crate, and in the ibc-types crates, are affected by this problem.

@conorsch conorsch moved this to Next in Testnets Oct 16, 2023
@aubrika aubrika moved this from Next to Testnet 64: Titan in Testnets Oct 18, 2023
@aubrika aubrika added this to Penumbra Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Oct 30, 2023
@aubrika aubrika moved this from 🗄️ Backlog to 📝 Todo in Penumbra Oct 30, 2023
@aubrika aubrika moved this from 📝 Todo to 🗄️ Backlog in Penumbra Nov 16, 2023
@erwanor erwanor moved this from Testnet 64: Titan to Testnet 65: Deimos in Testnets Jan 8, 2024
@aubrika aubrika added the _P-high High priority label Feb 8, 2024
@hdevalence
Copy link
Member

@avahowell said this didn't seem to affect us, I'll wait for a comment describing why.

@aubrika aubrika added this to the Sprint 0 milestone Feb 13, 2024
@aubrika aubrika moved this from 🗄️ Backlog to Todo in Penumbra Feb 13, 2024
@avahowell
Copy link
Contributor

The equivalent logic for this exists in our ibc-types-lightclients-tendermint:

https://github.com/penumbra-zone/ibc-types/blob/ca4cc5e9e936f229b346d19e248ec7088aed3dba/crates/ibc-types-lightclients-tendermint/src/header.rs#L110

we don't have this incorrect check, so we're not affected by this specific issue. However there are a few validations being performed that aren't present there. I will make a PR to ibc-types to add those.

@github-project-automation github-project-automation bot moved this from Todo to Done in Penumbra Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_P-high High priority
Projects
Archived in project
Status: Testnet 65: Deimos
Development

No branches or pull requests

4 participants