Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex(path_search): test liquidity heuristic with ibc assets #3039

Closed
Tracked by #1724
erwanor opened this issue Sep 15, 2023 · 3 comments
Closed
Tracked by #1724

dex(path_search): test liquidity heuristic with ibc assets #3039

erwanor opened this issue Sep 15, 2023 · 3 comments
Assignees

Comments

@erwanor
Copy link
Member

erwanor commented Sep 15, 2023

Is your feature request related to a problem? Please describe.
To decide what part of the liquidity graph to explore, the DEX uses a combination of fixed candidates that act as safe defaults, as well as dynamically elected candidates based on a liquidity heuristic (#2843).

Now that the IBC implementation is coming together, it would be good to actually test the liquidity indexing by depositing a large number of assets and asserting that the subset of the graph that is explored matches the pairs with most counterparty liquidity.

@erwanor erwanor added this to the Security audit milestone Sep 15, 2023
@erwanor erwanor added this to Testnets Sep 15, 2023
@erwanor erwanor moved this to Future in Testnets Sep 15, 2023
@erwanor erwanor removed this from the Security audit milestone Sep 15, 2023
@hdevalence
Copy link
Member

I think we could backburner this for a while, until we have multiple IBC paths.

@aubrika aubrika added this to Penumbra Oct 30, 2023
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Oct 30, 2023
@erwanor
Copy link
Member Author

erwanor commented Jan 19, 2024

To clarify, this issue is not about testing IBC-equivalency. Instead, this is about testing that the liquidity indices that the path search algo. The connection with IBC is that we can test that non-default assets are used by making IBC deposits, posting positions for those assets, and making sure that these assets are routable.

@erwanor erwanor self-assigned this Jan 19, 2024
@hdevalence
Copy link
Member

I think we should mark this as not planned, and subsume it into the more general task of exercising the DEX logic.

@hdevalence hdevalence closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to Done in Penumbra Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Status: Future
Development

No branches or pull requests

2 participants