Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use the latest ibc-proto and ics23 crates #3

Closed
Tracked by #2379
, #2391
...
hdevalence opened this issue Apr 18, 2023 · 5 comments
Closed
Tracked by #2379
, #2391
...

Update to use the latest ibc-proto and ics23 crates #3

hdevalence opened this issue Apr 18, 2023 · 5 comments
Assignees
@erwanor

Comments

@hdevalence
Copy link
Member

Doing this after vendoring checks in penumbra-zone/penumbra#2381 means we can save time by deleting any incompatible code in ibc-types.
@hdevalence hdevalence mentioned this issue Apr 18, 2023
Open
13 tasks
@hdevalence hdevalence moved this to Testnet 51: Elara in Testnets Apr 19, 2023
@hdevalence hdevalence mentioned this issue Apr 19, 2023
Closed
7 tasks
@avahowell
Copy link
Contributor

This currently isn't possible, because ibc-proto vendors its own copy of the ICS23 protos, and that vendored copy does not have the newest proofspec changes. I think ibc-proto will have to cut a new release with updated ics23 protos.

image

@romac
Copy link
Contributor

romac commented Apr 22, 2023

I think ibc-proto will have to cut a new release with updated ics23 protos.

I have a pending PR on ibc-proto with re-exports the latest ics23 structs (including the prehash_key_before_comparison field) directly instead of vendoring its protos: cosmos/ibc-proto-rs#92

It's currently blocked by this PR on ics23 (cosmos/ics23#146) but once it's in I can do a release of ibc-proto with these changes if they work for you.

@hdevalence
Copy link
Member Author

Amazing! That would be great.

@conorsch conorsch moved this from Testnet 51: Elara to Testnet 52: Amalthe in Testnets Apr 24, 2023
@erwanor erwanor self-assigned this Apr 27, 2023
@hdevalence
Copy link
Member Author

I copied the contents of that branch into a penumbra branch on our fork of ibc-proto, so that we can move forward: https://github.com/penumbra-zone/ibc-proto-rs/tree/penumbra

@erwanor erwanor mentioned this issue May 10, 2023
Closed
@erwanor erwanor moved this from Testnet 52: Amalthe to Testnet 53: Himalia in Testnets May 11, 2023
@erwanor erwanor mentioned this issue May 24, 2023
Merged
@redshiftzero redshiftzero removed the status in Testnets May 26, 2023
@redshiftzero redshiftzero moved this to Testnet 53: Himalia in Testnets May 26, 2023
@redshiftzero
Copy link

Done on 0.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwanor erwanor

Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 53: Himalia
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hdevalence @romac @redshiftzero @erwanor @avahowell