Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integration between fit and class attributes #33

Closed
Nicholas-Schaub opened this issue Jan 19, 2022 · 0 comments · Fixed by #34
Closed

Better integration between fit and class attributes #33

Nicholas-Schaub opened this issue Jan 19, 2022 · 0 comments · Fixed by #34
Assignees
@Nicholas-Schaub
Labels
enhancement New feature or request

Comments

@Nicholas-Schaub
Copy link
Collaborator

The current implementation of fit does not use the scoring attributed of the BaSiC model.
@Nicholas-Schaub Nicholas-Schaub added the enhancement New feature or request label Jan 19, 2022
@Nicholas-Schaub Nicholas-Schaub self-assigned this Jan 19, 2022
@Nicholas-Schaub Nicholas-Schaub linked a pull request Jan 20, 2022 that will close this issue
Fix/fit #34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicholas-Schaub Nicholas-Schaub

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/fit Nicholas-Schaub/PyBaSiC
1 participant
@Nicholas-Schaub