Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sock source for GPSD socket #1674

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

michielp1807
Copy link
Contributor

This PR builds on #1673 to add a sock time source for GPSD sockets.

The sock source can for example be configured as follows in the config file:

[[source]]
mode = "sock"
path = "/run/chrony.ttyAMA0.sock"
measurement_noise_estimate = 0.001

The NTP daemon will create the socket, which means that if you (re-)start GPSD, GPSD will send time data to us.

@michielp1807 michielp1807 force-pushed the sock-measurements branch 2 times, most recently from cb73865 to f3864c1 Compare October 3, 2024 14:50
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 73.46939% with 182 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (dfdcb5b) to head (bb9c4fd).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
ntpd/src/daemon/system.rs 0.00% 51 Missing ⚠️
ntpd/src/daemon/sock_source.rs 83.84% 37 Missing ⚠️
ntpd/src/force_sync/algorithm.rs 0.00% 32 Missing ⚠️
ntp-proto/src/system.rs 55.81% 19 Missing ⚠️
ntpd/src/daemon/spawn/sock.rs 79.45% 15 Missing ⚠️
ntp-proto/src/source.rs 70.96% 9 Missing ⚠️
ntpd/src/daemon/spawn/mod.rs 57.89% 8 Missing ⚠️
ntp-proto/src/algorithm/kalman/source.rs 97.36% 4 Missing ⚠️
ntpd/src/daemon/config/mod.rs 0.00% 2 Missing ⚠️
ntpd/src/daemon/config/ntp_source.rs 71.42% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   81.54%   81.44%   -0.11%     
==========================================
  Files          64       66       +2     
  Lines       20090    20496     +406     
==========================================
+ Hits        16382    16692     +310     
- Misses       3708     3804      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidv1992 davidv1992 changed the base branch from main to observe-measurement-buffer October 17, 2024 11:35
@davidv1992 davidv1992 changed the base branch from observe-measurement-buffer to main October 17, 2024 11:35
@michielp1807 michielp1807 linked an issue Nov 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement support for the SOCK protocol
2 participants