Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make issue pallet benchmarks run successfully on Pendulum runtimes #528

Closed
bogdanS98 opened this issue May 22, 2024 · 1 comment · Fixed by #535
Closed

Make issue pallet benchmarks run successfully on Pendulum runtimes #528

bogdanS98 opened this issue May 22, 2024 · 1 comment · Fixed by #535
Assignees

Comments

@bogdanS98
Copy link
Contributor

Context

The problem is that on the testchain runtime, we are defining the relay chain currency ID for the griefing collateral, see here. On our actual production runtimes we use the native currency. Since these calls only mint the 'collateral token' into the accounts used for benchmarking and not the native token, the call to requestIssue() fails to lock the griefing collateral in the native currency.
As we want to keep having the griefing collateral denoted in the native currency, we should change the benchmark logic so that also the 'griefing collateral currency' token is minted here.

In addition to this, we should have the amount used in the benchmark here match the 'minimum transfer amount' here so that we don't get AmountBelowMinimumTransferAmount error when running the benchmarks.

Requirement

Provide fixes for all of the above and re-run benchmarks for issue pallet on Spacewalk

@bogdanS98 bogdanS98 self-assigned this May 22, 2024
@ebma
Copy link
Member

ebma commented May 22, 2024

In addition to this, we should have the amount used in the benchmark here match the 'minimum transfer amount' here so that we don't get AmountBelowMinimumTransferAmount error when running the benchmarks.

Might make sense to also check if we can/should add the same improvement to other pallets ie. redeem and replace @bogdanS98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants