Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exported metrics for usage in Grafana dashboards #368

Closed
ebma opened this issue Jul 6, 2023 · 3 comments · Fixed by #468
Closed

Improve exported metrics for usage in Grafana dashboards #368

ebma opened this issue Jul 6, 2023 · 3 comments · Fixed by #468
Assignees
Labels

Comments

@ebma
Copy link
Member

ebma commented Jul 6, 2023

To make it easier to label the respective metrics in Grafana dashboards, see this ticket, we should add another field to the metrics emitted by the prometheus exporter of the Spacewalk client.

TODO

We should add a field called display_name or similar to each exported metric. This display_name should be compact but expressive. It should mention the currency, but also combine the fields status or type into it, if available.

Examples

  • The issue/redeem count gauges should say something like:
issue_count{currency="XCM(0)_Stellar(USDC:GAK...)", status="completed", display_name="XCM(0)_USDC - completed"}
issue_count{currency="XCM(0)_Stellar(USDC:GAK...)", status="expired", display_name="XCM(0)_USDC - expired"}
issue_count{currency="XCM(0)_Stellar(USDC:GAK...)", status="open", display_name="XCM(0)_USDC - open"}
  • The stellar balance gauges should say something like:
stellar_balance{currency="XCM(0)_Stellar(USDC:GAK...)", type="actual", display_name="XCM(0)_USDC - actual"}
stellar_balance{currency="XCM(0)_Stellar(USDC:GAK...)", type="actual", display_name="XCM(0)_USDC - required lowerbound"}
stellar_balance{currency="XCM(0)_Stellar(USDC:GAK...)", type="actual", display_name="XCM(0)_USDC - required upperbound"}

For context, this is how metrics are exported at the moment.
image

@ebma
Copy link
Member Author

ebma commented Jul 6, 2023

Hey team! Please add your planning poker estimate with Zenhub @adelarja @b-yap

@ebma ebma added the priority:medium Do it soon label Jul 6, 2023
@TorstenStueber
Copy link
Contributor

@ebma is this still relevant? If yes, please move to Ready.

Also note that this ticket here blocks https://app.zenhub.com/workspaces/pendulum-6408a0365cda59c57d39bee5/issues/gh/pendulum-chain/tasks/40

@ebma
Copy link
Member Author

ebma commented Dec 19, 2023

Yes, I think this is still relevant.

@gianfra-t gianfra-t self-assigned this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants