Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clippy --fix to pre-commit script #153

Closed
ebma opened this issue Dec 20, 2022 · 5 comments · Fixed by #488
Closed

Add clippy --fix to pre-commit script #153

ebma opened this issue Dec 20, 2022 · 5 comments · Fixed by #488
Assignees
@gianfra-t
Labels
priority:low Do it some day type:chore Maintenance tasks

Comments

@ebma
Copy link
Member

ebma commented Dec 20, 2022

It might be a good idea to add a clippy --fix command to the existing pre-commit script. It can automatically apply some best practices to the code, which the CI is likely to complain about anyways.
@ebma ebma added the priority:low Do it some day label Dec 20, 2022
@prayagd
Copy link
Collaborator

prayagd commented May 3, 2023

Hey team! Please add your planning poker estimate with Zenhub @b-yap @ebma @TorstenStueber

@prayagd
Copy link
Collaborator

prayagd commented Jun 15, 2023

@ebma Do we need this for the public launch ?

@ebma
Copy link
Member Author

ebma commented Jun 16, 2023

No, it's just for our own developer experience. It's not necessary for the product.

@TorstenStueber
Copy link
Contributor

@ebma can we move this to the Ready column?

@TorstenStueber TorstenStueber mentioned this issue Dec 19, 2023
Closed
@ebma
Copy link
Member Author

ebma commented Dec 19, 2023

Yes sure. @pendulum-chain/product this is probably a 10-minute task so would be nice to have it in 'ready'.

@TorstenStueber TorstenStueber added the type:chore Maintenance tasks label Dec 23, 2023
@gianfra-t gianfra-t self-assigned this Feb 8, 2024
@gianfra-t gianfra-t mentioned this issue Feb 9, 2024
Merged
@gianfra-t gianfra-t linked a pull request Feb 9, 2024 that will close this issue
Adding cargo fix to pre-commit hook #488
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gianfra-t gianfra-t

Labels
priority:low Do it some day type:chore Maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding cargo fix to pre-commit hook pendulum-chain/spacewalk
4 participants
@ebma @TorstenStueber @prayagd @gianfra-t