-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC20 and oracle chain extension to Amplitude and Pendulum #356
Comments
Hey team! Please add your planning poker estimate with Zenhub @ebma @bogdanS98 @b-yap @gianfra-t |
Please add your planning poker estimate with Zenhub @TorstenStueber |
@TorstenStueber we already have a ticket to extract and re-use the chain extension here. Since we want to have this chain extension on Pendulum very soon, I'd suggest we duplicate the code for now and extract and deduplicate it in a follow-up PR for the other ticket. |
Are there any specific operations that should be done, in order to test this change? |
Hmm you could try uploading the wrapper contract for the native token in zombienet and call some functions on it. Then we know whether it works. |
The chain extension developed for Foucoco that contains the code used by the ERC20 wrapper contracts and the oracle wrapper contract should also be added to Amplitude and Pendulum.
It might makes sense to deduplicate code and move the chain extension into runtime/common, however, we should carefully check what effects this can have and whether the code is compatible with all three runtimes.
The text was updated successfully, but these errors were encountered: