Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency from Forked Zenlink to Original Zenlink once pendulum upgrade polkadot version to polkadot-v0.9.38 #222

Closed
RustNinja opened this issue Apr 20, 2023 · 6 comments · Fixed by #382
Labels
priority:low Do it some day

Comments

@RustNinja
Copy link
Contributor

Issue related to #217 and #219
and problem produced by different version of jsonrpsee here is fixed issue in forked version : pendulum-chain/Zenlink-DEX-Module#1

Todo list:
once pendulum repo will upgraded to polkadot-v0.9.38 it is good idea to replace dependency from forked version to original version. because original version has a proper dependency of jsonrpsee that does not force us to use a forked version.

https://github.com/pendulum-chain/Zenlink-DEX-Module
to
https://github.com/zenlinkpro/Zenlink-DEX-Module

@vadaynujra
Copy link

@ebma Is this required for the initial integration with Zenlink? If not, do you know when this would be required?

@ebma ebma added the priority:low Do it some day label Jun 14, 2023
@ebma
Copy link
Member

ebma commented Jun 14, 2023

@vadaynujra this is never ever 'required'. It's just nice to have and acts as a reminder of why we had to use a forked version of the Zenlink pallet basically. We might be able to close it in a few weeks, once Zenlink updates their code to 0.9.40 (as we decided to skip upgrading to 0.9.38 and immediately reached for 0.9.40 but this now makes us rely on the fork again, because they didn't update their code to that version yet).

@prayagd
Copy link
Collaborator

prayagd commented Dec 7, 2023

Moving to icebox

@TorstenStueber
Copy link
Contributor

@ebma @gianfra-t could we actually work on this now with the upgrade to Polkadot v0.9.42?

@gianfra-t
Copy link
Contributor

Yes, actually in the upgrade pr we are already using the zenlinkpro repo.

@TorstenStueber
Copy link
Contributor

Great. So then we can close this ticket once the other PR is merged.

@ebma ebma mentioned this issue Jan 9, 2024
@ebma ebma closed this as completed in #382 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Do it some day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants