-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dependency from Forked Zenlink to Original Zenlink once pendulum upgrade polkadot version to polkadot-v0.9.38 #222
Comments
@ebma Is this required for the initial integration with Zenlink? If not, do you know when this would be required? |
@vadaynujra this is never ever 'required'. It's just nice to have and acts as a reminder of why we had to use a forked version of the Zenlink pallet basically. We might be able to close it in a few weeks, once Zenlink updates their code to |
Moving to icebox |
@ebma @gianfra-t could we actually work on this now with the upgrade to Polkadot v0.9.42? |
Yes, actually in the upgrade pr we are already using the |
Great. So then we can close this ticket once the other PR is merged. |
Issue related to #217 and #219
and problem produced by different version of
jsonrpsee
here is fixed issue in forked version : pendulum-chain/Zenlink-DEX-Module#1Todo list:
once pendulum repo will upgraded to
polkadot-v0.9.38
it is good idea to replace dependency from forked version to original version. because original version has a proper dependency ofjsonrpsee
that does not force us to use a forked version.https://github.com/pendulum-chain/Zenlink-DEX-Module
to
https://github.com/zenlinkpro/Zenlink-DEX-Module
The text was updated successfully, but these errors were encountered: