Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly recognize whether a contract call reverted #21

Merged

Conversation

TorstenStueber
Copy link
Member

Closes #20

Additionally it changes some other settings required for using yarn 4.5.

@TorstenStueber TorstenStueber linked an issue Sep 30, 2024 that may be closed by this pull request
@TorstenStueber TorstenStueber force-pushed the 20-bug-correctly-detect-whether-a-contract-call-reverted branch from 9d87dac to afcf66d Compare September 30, 2024 19:42
@TorstenStueber TorstenStueber requested a review from a team September 30, 2024 19:43
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall 👍

src/contractRpc.ts Show resolved Hide resolved
@TorstenStueber TorstenStueber merged commit 229bba8 into main Oct 2, 2024
@ebma ebma deleted the 20-bug-correctly-detect-whether-a-contract-call-reverted branch October 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Correctly detect whether a contract call reverted
3 participants