Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserving existing comments whilst editing TOML files #207

Closed
alankm opened this issue Jan 11, 2018 · 4 comments
Closed

Preserving existing comments whilst editing TOML files #207

alankm opened this issue Jan 11, 2018 · 4 comments
Labels
document Issues related to Document Editing feature Issue asking for a new feature in go-toml.

Comments

@alankm
Copy link
Contributor

alankm commented Jan 11, 2018

Are there any methods or plans to edit the data in an existing TOML file without destroying existing comments?
@pelletier pelletier added the question Question from a go-toml user. label Jan 18, 2018
@pelletier
Copy link
Owner

There have been some talk about that, but nothing exists at the moment. This would indeed be a nice feature.

@pelletier pelletier added feature Issue asking for a new feature in go-toml. and removed question Question from a go-toml user. labels Mar 1, 2019
@pelletier pelletier added this to the Document support milestone Mar 1, 2019
@pelletier pelletier changed the title Preserving existing comments whilst editing TOML files. Preserving existing comments whilst editing TOML files Apr 2, 2019
@juan131
Copy link

juan131 commented Oct 15, 2019

Hi @pelletier

Any advance on this feature? It's essential (specially when dealing with configuration files) to preserve the comments since they're fundamental to understand the available parameters.

@pelletier
Copy link
Owner

Haven't made any progress myself on it – my free time is spreading thin. Pull requests welcomed!

@pelletier pelletier added the document Issues related to Document Editing label Oct 23, 2021
@pelletier pelletier removed this from the v2.0.0-beta.4 milestone Oct 23, 2021
@pelletier
Copy link
Owner

Closing this issue, as go-toml v2.0.0 has been released, and document manipulation is out of scope for v2. As go-toml v1 will not be receiving any updates, please look into upgrading to the new version. If you believe this is a mistake please reach out!

@mmarchetti mmarchetti mentioned this issue Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
document Issues related to Document Editing feature Issue asking for a new feature in go-toml.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pelletier @juan131 @alankm