fix(CI): update elastic_wait command usage

pelias · Nov 20, 2019 · bc2d83f · bc2d83f
1 parent 7a3088f
commit bc2d83f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/scripts/elastic_wait.sh b/scripts/elastic_wait.sh
@@ -1,5 +1,11 @@
+set -e
+
 function elastic_status(){
-  curl --output /dev/null --silent --write-out "%{http_code}" "http://${ELASTIC_HOST:-localhost:9200}" || true;
+  curl \
+    --output /dev/null \
+    --silent \
+    --write-out "%{http_code}" \
+    "http://${ELASTIC_HOST:-localhost:9200}" || true;
 }
 
 function elastic_wait(){
@@ -9,7 +15,7 @@ function elastic_wait(){
   i=1
   while [[ "$i" -le "$retry_count" ]]; do
     if [[ $(elastic_status) -eq 200 ]]; then
-      echo "Elasticsearch up!"
+      echo
       exit 0
     fi
     sleep 2
@@ -20,4 +26,4 @@ function elastic_wait(){
   echo
   echo "Elasticsearch did not come up, check configuration"
   exit 1
-}
+}
diff --git a/scripts/setup_ci.sh b/scripts/setup_ci.sh
@@ -37,7 +37,7 @@ fi
 # wait for server to boot up
 # logs show that on travis-ci it can take ~17s to boot an ES6 server
 source "${BASH_SOURCE%/*}/elastic_wait.sh"
-elastic_wait
+(elastic_wait)
 
 # set the correct esclient.apiVersion in pelias.json
 v=( ${ES_VERSION//./ } ) # split version number on '.'
@@ -48,4 +48,4 @@ echo "--- pelias.json ---"
 cat ~/pelias.json
 
 echo "--- elasticsearch.yml ---"
-cat /tmp/elasticsearch/config/elasticsearch.yml
+cat /tmp/elasticsearch/config/elasticsearch.yml