Replace all usage of alpha3/admin0/admin1 with country_a/country/region #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // { 'type': { 'value': 'local_admin' } }, | ||
| // { 'type': { 'value': 'neighborhood' } } | ||
| // { 'type': { 'value': 'localadmin' } }, | ||
| // { 'type': { 'value': 'neighbourhood' } } |
There was a problem hiding this comment.
gotta keep that commented out code up to date :P
|
👍 |
|
dianashk
pushed a commit
that referenced
this pull request
Feb 29, 2016
Replace all usage of alpha3/admin0/admin1 with country_a/country/region
orangejulius
added a commit
to pelias/schema
that referenced
this pull request
Nov 3, 2018
We stopped using the `alpha3` field over [two years ago](pelias/query#6), but it was still lingering in our schema including some tests. This was discovered while updating and testing #282.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alpha3,admin0, andadmin1tocountry_a,region, andregion_arespectively_ainstead of_abbrin order to better match the Pelias-API result formattingConnected to pelias/api#424