Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An in-range update of tape is breaking the build 🚨 #33

Closed
greenkeeper bot opened this issue Feb 9, 2019 · 1 comment · Fixed by #34
Closed

An in-range update of tape is breaking the build 🚨 #33

greenkeeper bot opened this issue Feb 9, 2019 · 1 comment · Fixed by #34
Labels
greenkeeper

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Feb 9, 2019

The devDependency tape was updated from 4.9.2 to 4.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tape is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
Commits

The new version differs by 60 commits.

  • 34b1832 v4.10.0
  • 6209882 Merge all orphaned tags: 'v1.1.2', 'v2.0.2', 'v2.1.1', 'v2.2.2', 'v2.3.3', 'v2.4.3', 'v2.5.1', 'v2.6.1', 'v2.7.3', 'v2.8.1', 'v2.9.1', 'v2.10.3', 'v2.11.1', 'v2.13.4', 'v2.14.0', 'v2.14.1', 'v3.6.1'
  • 82e7b26 [Deps] update glob
  • 9e3d25e [Dev Deps] update eslint, js-yaml
  • fd807f5 v1.1.2
  • eddbff5 v2.14.1
  • 6ce09d9 Minor test tweaks due to whitespace differences in v2 vs v4.
  • 71af8ba gitignore node_modules
  • 4c0d9e6 Merge pull request #268 from ljharb/throws_non_function_should_fail
  • d0a675f v3.6.1
  • d22b5fc Minor test tweaks due to output differences in v1 vs v4.
  • 8b3c1b7 Add missing concat-stream devDep
  • 3495543 gitignore node_modules
  • db81846 Merge pull request #268 from ljharb/throws_non_function_should_fail
  • 7ed6651 Minor test tweaks due to whitespace differences in v3 vs v4.

There are 60 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 9, 2019

After pinning to 4.9.2 your tests are passing again. Downgrade this dependency 📌.

orangejulius added a commit that referenced this issue Feb 11, 2019
@orangejulius
chore(tests): Add explicit ends to base level tests
4ebd277 
In a recent release, `tape` fixed a bug
(tape-testing/tape#458) which ends up also being a
major breaking change.

Essentially, any time tests are nested, both the nested and top level
tests must call `end()`. This appears to have affected many of our
repositories, as we heavily use nested tests.

Fixes #33
@orangejulius orangejulius mentioned this issue Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
greenkeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): Add explicit ends to base level tests pelias/microservice-wrapper
0 participants