-
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(tests): Add explicit ends to base level tests
In a recent release, `tape` fixed a bug (tape-testing/tape#458) which ends up also being a major breaking change. Essentially, any time tests are nested, both the nested and top level tests must call `end()`. This appears to have affected many of our repositories, as we heavily use nested tests. Fixes #33
- Loading branch information
1 parent
0c286a6
commit 4ebd277
Showing
3 changed files
with
10 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,5 +89,6 @@ tape('ServiceConfiguration tests', (test) => { | |
t.end(); | ||
|
||
}); | ||
test.end(); | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters