Skip to content

Commit

Permalink
chore(tests): Add explicit ends to base level tests
Browse files Browse the repository at this point in the history
In a recent release, `tape` fixed a bug
(tape-testing/tape#458) which ends up also being a
major breaking change.

Essentially, any time tests are nested, both the nested and top level
tests must call `end()`. This appears to have affected many of our
repositories, as we heavily use nested tests.

Fixes #33
  • Loading branch information
orangejulius committed Feb 11, 2019
1 parent 0c286a6 commit 4ebd277
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions test/ServiceConfiguration.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,6 @@ tape('ServiceConfiguration tests', (test) => {
t.end();

});
test.end();

});
1 change: 1 addition & 0 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ tape('index tests', (test) => {
t.equals(typeof index.ServiceConfiguration, 'function');
t.end();
});
test.end();
});
9 changes: 8 additions & 1 deletion test/service.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ tape('service tests', (test) => {
t.end();
});

test.end();

});

tape('conforms_to tests', (test) => {
Expand All @@ -31,6 +33,7 @@ tape('conforms_to tests', (test) => {

});

test.end();
});

tape('request logging', (test) => {
Expand Down Expand Up @@ -123,6 +126,7 @@ tape('request logging', (test) => {
});

});
test.end();

});

Expand All @@ -148,6 +152,7 @@ tape('service disabled tests', (test) => {
});

});
test.end();

});

Expand Down Expand Up @@ -564,6 +569,7 @@ tape('failure conditions tests', (test) => {
});

});
test.end();

});

Expand Down Expand Up @@ -768,6 +774,7 @@ tape('success conditions tests', (test) => {
});

});
test.end();

});

Expand Down Expand Up @@ -845,5 +852,5 @@ tape('callback-as-2nd-parameter tests', (test) => {
});

});

test.end();
});

0 comments on commit 4ebd277

Please sign in to comment.