Mark tests passing from synyonm overhaul #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
synonym-improvements
branch
from
c89f3bc to
0c222ce
Compare
Fixed by pelias/schema#453 Connects pelias/api#783
Fixed by pelias/schema#453 Connects pelias/schema#301
These are all fixed by pelias/schema#453
French addresses are relevant here: pelias/schema#301
orangejulius
force-pushed
the
synonym-improvements
branch
from
0c222ce to
37a47f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pelias/schema#453 we have some major improvements to the Pelias synonym system used to handle most abbreviations.
As a result of that work, 9 acceptance tests are now passing. This PR marks those as testing and if they represent a particular github issue that is clearly now resolved, marks that issue as fixed.
Some overall issues like pelias/api#783 and pelias/schema#301 for Spanish and French addresses are not marked as fixed, but we should go through the discussions there to see if they've effectively been resolved.