Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPH-87 - Choice of range proof params in cli wallet reveals transaction magnitude to very narrow range for Blinded transfers #112

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

GRPH-87 - Choice of range proof params in cli wallet reveals transaction magnitude to very narrow range for Blinded transfers #112

wants to merge 1 commit into from

Conversation

srpatel19590
Copy link

@bobinson bobinson added the security security and stablity fixes label Sep 5, 2019
@bobinson bobinson requested a review from oxarbitrage September 5, 2019 08:34
@srpatel19590 srpatel19590 mentioned this pull request Sep 9, 2019
Closed
@srpatel19590
Copy link
Author

@bobinson I will resolve conflicts here once you merge GRPH-3

@oxarbitrage
Copy link

I think we can close this one and add a new one where only the code related to the fix is present. This code can be found at https://github.com/bitshares/bitshares-core/pull/1117/files

@bobinson bobinson self-requested a review September 12, 2019 12:02
bobinson
bobinson approved these changes Sep 12, 2019
View reviewed changes
Copy link

@bobinson bobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make a clean PR as per @oxarbitrage 's suggestion. Sorry about the rework ...

@srpatel19590
Copy link
Author

@bobinson This PR is updated as per your request.

oxarbitrage
oxarbitrage suggested changes Sep 13, 2019
View reviewed changes
Copy link

@oxarbitrage oxarbitrage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing.

I added a log here: https://github.com/oxarbitrage/logs/blob/master/pp_pull112

@srpatel19590
Copy link
Author

srpatel19590 commented Sep 14, 2019 •
edited
Loading

It will work once you merge #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage requested changes

@bobinson bobinson bobinson approved these changes

Assignees
No one assigned
Labels
security security and stablity fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srpatel19590 @oxarbitrage @bobinson