Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 - Archive_Tar->_readHeader() throws deprecations #24

Closed
mondrake opened this issue Oct 20, 2019 · 3 comments · Fixed by #25
Closed

PHP 7.4 - Archive_Tar->_readHeader() throws deprecations #24

mondrake opened this issue Oct 20, 2019 · 3 comments · Fixed by #25

Comments

@mondrake
Copy link

Testing PHP 7.4 with Drupal 8.8.x we get the following error:

PHPUnit 7.5.16 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\config\Functional\ConfigImportUploadTest
E                                                                   1 / 1 (100%)

Time: 7.46 seconds, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\config\Functional\ConfigImportUploadTest::testImport
Exception: Deprecated function: Invalid characters passed for attempted 
conversion, these have been ignored
Archive_Tar->_readHeader()() (Line: 1695)


/var/www/html/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpCl
ientMiddleware.php:51
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:203
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:156
/var/www/html/vendor/guzzlehttp/promises/src/TaskQueue.php:47
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:246
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:223
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:267
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:225
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:62
/var/www/html/vendor/guzzlehttp/guzzle/src/Client.php:131
/var/www/html/vendor/fabpot/goutte/Goutte/Client.php:180
/var/www/html/vendor/symfony/browser-kit/Client.php:318
/var/www/html/vendor/symfony/browser-kit/Client.php:259
/var/www/html/vendor/behat/mink-browserkit-
driver/src/BrowserKitDriver.php:696
/var/www/html/vendor/behat/mink-browserkit-
driver/src/BrowserKitDriver.php:480
/var/www/html/vendor/behat/mink/src/Element/NodeElement.php:153
/var/www/html/vendor/behat/mink/src/Element/NodeElement.php:161
/var/www/html/core/tests/Drupal/Tests/UiHelperTrait.php:100
/var/www/html/core/tests/Drupal/Tests/UiHelperTrait.php:209
/var/www/html/core/modules/config/tests/src/Functional/ConfigImportUpl
oadTest.php:50

ERRORS!
Tests: 1, Assertions: 9, Errors: 1.

@mrook
Copy link
Member

mrook commented Oct 20, 2019

Interesting, the tests seem to pass on 7.4. Can you attach the archive that's failing for you? There seems to be something going on with the checksum.

@alexpott
Copy link
Contributor

What's failing for us is a test where we're testing passing an archive that's not an archive to ArchiveTar - we're just throwing a text file at it. In PHP 7.3 and below we catch the error and display a useful message to the user. On PHP7.4 the checksum gPO:.cM< causes a deprecation error.

The file we're using: text-0.txt

@alexpott
Copy link
Contributor

This is what we're dealing with https://3v4l.org/6bshb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants