Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a new release with updated github.com/lanrat/extsort version #717

Closed
gkowarzyk opened this issue Apr 24, 2024 · 4 comments · Fixed by #778
Closed

Comments

@gkowarzyk
Copy link

Hello,

The github.com/lanrat/extsort library has created a new release tag (v1.0.1), which includes the latest fixes, and changes the license from GPL to an Apache v2 license.

Please create a new release with the updated github.com/lanrat/extsort version, as it would allow s5cmd to include the new license in its dependencies instead.

Thanks in advance!

@Redeys

This comment was marked as spam.

@Redeys

This comment was marked as spam.

@ilkinulas ilkinulas added this to s5cmd Jun 28, 2024
@kucukaslan
Copy link
Contributor

Hi team,

What do you think about upgrading extsort's version?

I suppose updating go.mod and vendor/ would be enough. If needed I can open a PR.

Ideally a github action, using https://github.com/google/go-licenses, to check license compatibility can be added to ensure such a mistake won't happen again but I cannot promise doing it.

I also want to make a kind of reflection (retro?) since I was the one added this dependency 😅 .
I vaguely remember that I checked the license because I was interested in FOSS and inter-compability of GNU-GPL license variants with ours.
at lanrat/extsort#3 we see that project license was changed to Apache in 2021 (a year before we started using it) at GitHub repo. Probably, I merely checked the GitHub repo and thought it is fine, and did not investigate further.

Bests

@jrnos
Copy link

jrnos commented Oct 23, 2024

I think it would be good to update the version in order to get Apache v2 license into effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants