Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish this action as GitHub App or Probot #63

Closed
peaceiris opened this issue Apr 8, 2020 · 7 comments
Closed

Publish this action as GitHub App or Probot #63

peaceiris opened this issue Apr 8, 2020 · 7 comments
Assignees
Labels

Comments

@peaceiris
Copy link
Owner

Is your feature request related to a problem? Please describe.

Provide this action as a GitHub App or Probot.
Suggested by @adfoster-r7 at #24 (comment)

Describe the solution you'd like

  • Register this action as a GitHub App OR
  • Add this action to the Probot families

Describe alternatives you've considered

GitHub provides:

  • write access for actions to comment on Pull Requests from forks
  • smaller scope (each repository) of a personal access token

Additional context

@adfoster-r7
Copy link

Just to cross link the issue I created in boring-cyborg - kaxil/boring-cyborg#18

The Github apps are pretty cool too, as there's much more granular restrictions that can be placed on Github Apps, such as read only access etc.

@adfoster-r7
Copy link

Looking at the Probot documentation it seems like the event to listen to is pull_request.labeled. After searching Github for this string, it seems there's similar art here too - https://github.com/dessant/label-actions - which seems to be using the probot API, but is still a Github Action

@peaceiris
Copy link
Owner Author

dessant/label-actions seems to satisfy your demand so you maybe leave here and use it.

Personally, I am interested in coexisting Probot and GitHub Actions. I will try to do it.

@peaceiris
Copy link
Owner Author

I found a project which shows a workaround as a PoC.

imjohnbo/ok-to-test: Use GitHub Actions secrets in pull requests from forks 🍴🔑

@Andre601
Copy link
Contributor

There already is a probot that comments on issues/PRs based on labels you set/remove and also performs actions like closing those and even locking them with optional reasons.

The bot is called Label Actions (https://github.com/apps/label-actions)

@peaceiris
Copy link
Owner Author

Thanks. Your link is the same as above.

Looking at the Probot documentation it seems like the event to listen to is pull_request.labeled. After searching Github for this string, it seems there's similar art here too - https://github.com/dessant/label-actions - which seems to be using the probot API, but is still a Github Action

@peaceiris
Copy link
Owner Author

This action starts to support the pull_request_target event. This problem has been solved. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants