feat: Use rsync instead of io.cp() #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 69.06% 69.06%
=======================================
Files 3 3
Lines 139 139
Branches 26 26
=======================================
Hits 96 96
Misses 43 43Continue to review full report at Codecov.
|
| core.info(`[INFO] copy ${file}`); | ||
| } else { | ||
| await exec.exec('rsync', [ | ||
| '-rptgoDv', |
There was a problem hiding this comment.
long args here would be nice to help viewers quickly know what's going on
There was a problem hiding this comment.
Long option name? --recursive instead of -r? I agree.
| '--copy-links', | ||
| '--copy-dirlinks', |
There was a problem hiding this comment.
From rsync --help:
-l, --links copy symlinks as symlinks
-L, --copy-links transform symlink into referent file/dir
--copy-unsafe-links only "unsafe" symlinks are transformed
--safe-links ignore symlinks that point outside the source tree
--munge-links munge symlinks to make them safer (but unusable)
-k, --copy-dirlinks transform symlink to a dir into referent dir
-K, --keep-dirlinks treat symlinked dir on receiver as dir
-H, --hard-links preserve hard links
Extended documentation at https://superuser.com/a/1388910
My understanding is that --copy-links includes --copy-dirlinks, such that you should only need to specify the former.
Related to my comment at #103 (comment) and from looking at the rsync docs, I think there are two options for this action:
--copy-links: dereference all symlinks--copy-unsafe-links: only dereference "unsafe" symlinks (symbolic links that point outside the copied tree)
I like option 2 the most because GitHub Pages can handle symlinks that point within the file tree. However, I can imagine users would like access to both modes. Some applications might want to dereference all symlinks while others might want to only dereference unsafe symlinks.
There was a problem hiding this comment.
Thank you for investigating.
I like option 2 the most because GitHub Pages can handle symlinks that point within the file tree. However, I can imagine users would like access to both modes. Some applications might want to dereference all symlinks while others might want to only dereference unsafe symlinks.
I have understood the two cases clearly.
|
I close this Pull Request to use the release 3.6.0 for another feature. This topic continues on #103 |
Prototype for #103