Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change base image from Debian to Ubuntu 18.04 #428

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

peaceiris
Copy link
Owner

@peaceiris peaceiris commented Jul 28, 2020

Change base docker image from node:x.x.x-buster-slim to ubuntu:18.04
The image size reduces from 1.05GB to 327MB

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #428 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files           4        4           
  Lines         279      279           
  Branches       50       50           
=======================================
  Hits          146      146           
  Misses        132      132           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49e738...b5da89f. Read the comment docs.

@peaceiris peaceiris merged commit 70c0076 into main Jul 28, 2020
@peaceiris peaceiris deleted the change-docker-base-image-from-debian-to-ubuntu18.04 branch July 28, 2020 12:47
peaceiris pushed a commit that referenced this pull request Jul 28, 2020
Change base docker image from `node:x.x.x-buster-slim` to `ubuntu:18.04`
The image size reduces from 1.05GB to 327MB

- Install Node.js via nodesource https://github.com/nodesource/distributions
- Install Git via ppa:git-core/ppa https://git-scm.com/download/linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant