option to commit .github files #163

pawsong · 2020-03-17T09:55:20Z

Thank you for sharing this good project :)

Is your feature request related to a problem? Please describe.
In some use cases, we want to commit .github workflow files so that we can trigger actions on gh-pages branch.

Describe the solution you'd like
An option to determine if .github files to commit or not.

Describe alternatives you've considered
I made a commit to disable .github filtering, but I know this is a temporary workaround.

specup@9cb1a7c

The text was updated successfully, but these errors were encountered:

peaceiris · 2020-03-17T10:02:48Z

Adding a new option exclude_files may be a good solution. I will think about the details.

.git should be always included in exclude_files.
Default: .git .github
When we set the option: .git file1 file2 ...

- name: Deploy
  uses: peaceiris/actions-gh-pages@v3
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    exclude_files: |
      .env
      .nvmrc

Why we should not add the .github to the gh-pages branch by default?
- We have this case publish_dir: ./

pawsong · 2020-03-17T10:36:09Z

If .git should be always excluded, then how about excluding .git regardless of exclude_files option?

Then default value of exclude_files would be .github.

pawsong · 2020-03-17T10:39:34Z

Setting default value of exclude_files to .github or .git .github... both options look reasonable to me.

peaceiris · 2020-03-17T10:49:07Z

Yes. We can exclude .git from a publish directory regardless of the exclude_files and define .github as a default value of the exclude_files option.

inputs:
  exclude_files:
    description: 'Set files to exclude from a publish directory.'
    required: false
    default: '.github'

peaceiris · 2020-03-17T11:15:27Z

To mean that the option has files or directories, we should probably call it exclude_assets.

inputs:
  exclude_assets:
    description: 'Set files or directories to exclude from a publish directory.'
    required: false
    default: '.github'

pawsong · 2020-03-17T11:23:36Z

How to exclude only files under .git directory? Possibly we can set exclude_assets to false or empty string ('').

pawsong · 2020-03-17T11:24:42Z

- name: Deploy
  uses: peaceiris/actions-gh-pages@v3
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    exclude_assets: false

Using false looks prettier for me.

peaceiris · 2020-03-17T11:26:47Z

Some users can have files that are named false or true, so I think empty is better.

pawsong · 2020-03-17T11:28:50Z

I agree with you. Using empty string is better.

Legion2 · 2020-03-17T11:29:16Z

Why not excluding all files and directories starting with . by default. Because they are considered invisible.

pawsong · 2020-03-17T11:30:11Z

Excluding all dot files will be a breaking change for existing users.

Legion2 · 2020-03-17T11:34:26Z

But else we have to discuss what is excluded by default. There are many dot files like the .gitignore you don't need to deploy to github pages. The simplest solution is to never deploy the root of the git repo, because it contains many configuration files.

peaceiris · 2020-03-17T11:38:05Z

For example, users who are using Static Site Generators (not GitHub Pages built-in Jekyll) need .nojekyll file.

@Legion2 See this case. Some users set publish_dir: ./ and others set a git submodule to publish_dir. So we should not exclude all dotfiles by default.

Legion2 · 2020-03-17T11:40:37Z

OK, but why should .github be excluded by default?

pawsong · 2020-03-17T11:59:43Z

@Legion2 The reason is described here

#163 (comment)

Some users use publish_dir: ./ in there source code branch

Legion2 · 2020-03-17T12:17:50Z

OK now I understand. When .github is not excluded, it will trigger some workflows on the github pages branch and that should not happen.

corollari · 2020-03-17T13:03:09Z

If you end up going with some variation of exclude_assets I'd propose adding a warning or something to the readme explaining why .github is excluded by default, as the reason is not trivial.

peaceiris · 2020-03-19T03:48:28Z

If you end up going with some variation of exclude_assets I'd propose adding a warning or something to the readme explaining why .github is excluded by default, as the reason is not trivial.

Yes! We need a friendly description of the option.

It is probably useful to enable regular expression for the exclude_assets option. I will work on this issue on the weekend.

radames · 2020-06-24T05:53:13Z

forget my last message, I'm using @pawsong specup/actions-gh-pages@master temporary fix! thanks

radames · 2020-06-24T06:11:38Z

also just realize I could merge the steps of my action and didn't need to have another YAML on gh-pages branch! thanks But I can see that having you feature to selective exclude_files is a great way to go! rather than hardcode filtering .github thanks

peaceiris · 2020-06-24T06:46:14Z

Thank you for your feedback!

Related to #163

Legion2 · 2020-07-25T12:16:37Z

The @actions/glob package can be used to handle the glob patterns. It supports different patterns to include and exclude files https://github.com/actions/toolkit/tree/master/packages/glob#patterns.

diauweb · 2020-07-25T12:17:15Z

v3.7.0-5 is working for me now

Related to #163 https://github.com/actions/toolkit/tree/main/packages/glob

peaceiris · 2020-07-25T13:04:01Z

The beta v3.7.0-6 has been released. exclude_assets supports glob patterns.

Could someone test this?

The exclude_assets option has .github by default.

- name: Deploy
  uses: peaceiris/[email protected]
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    # exclude_assets: ''  # Set empty to deploy .github
    # exclude_assets: 'exclude-file1,exclude-file2'  # Split multi files or directory with comma
    exclude_assets: '.github,exclude-file.txt,exclude-dir/**.txt'

ericleong · 2020-08-11T23:29:43Z

I am using peaceiris/[email protected]. I noticed a couple issues:

`.git`

Accidentally including .git in exclude_assets will cause the action to fail because git won't be able to commit the change:

[INFO] Keep existing files
[INFO] chdir /home/runner/actions_github_pages_1597182186809
[INFO] prepare publishing assets
...
[INFO] skip .git
[INFO] copy .github
...
[INFO] delete excluded assets
...
[INFO] delete /home/runner/actions_github_pages_1597182186809/.git
[INFO] delete /home/runner/actions_github_pages_1597182186809/.git/HEAD
[INFO] delete /home/runner/actions_github_pages_1597182186809/.git/config
...
[INFO] Created /home/runner/actions_github_pages_1597182186809/.nojekyll
[endgroup]
[group]Setup Git config
[command]/usr/bin/git remote rm origin
9343996Z fatal: not a git repository (or any of the parent directories): .git
[INFO] The process '/usr/bin/git' failed with exit code 128
[command]/usr/bin/git remote add origin ***github.com/ericleong/zoomwall.js.git
9440914Z fatal: not a git repository (or any of the parent directories): .git
[error]Action failed with "The process '/usr/bin/git' failed with exit code 128"

I am not very familiar with YAML so I also forgot to quote the exclude_assets parameter in the above example. In any case, an overly greedy glob like .* will include .git, so even though .git is not copied to the destination, it's still deleted.

Comma-delimiting

string.split(',') won't work for globs that have commas, like **/*.{js,ts}. A library like split-string could be used to split a list of quoted strings that have delimiters in them.

Personally I would rather have the list of files be separated by spaces because that is the shell convention:

exclude_assets: '.github "exclude file.txt" exclude-dir/**.{md,txt}'

Another idea is to use a YAML list:

exclude_assets: 
  - '.github'
  - 'exclude file.txt'
  - 'exclude-dir/**.{md,txt}'

peaceiris · 2020-08-12T05:14:11Z

Thank you for the report and suggestion.

Enhancement

Accidentally including .git in exclude_assets

In any case, an overly greedy glob like .* will include .git, so even though .git is not copied to the destination, it's still deleted.

Since this action always ignores .git by default, we do not need to set .git to exclude_assets. (You can find the message [INFO] skip .git in your log.) But we need to ignore the case that a user sets .git to exclude_assets or an overly greedy glob like .*.

Supporting a pattern `**/*.{js,ts}`

**/*.{js,ts}

Currently, this action depends on toolkit/packages/glob for expanding a glob pattern and it does not support this case **/*.{js,ts} I will find an alternative.

toolkit/packages/glob

Patterns *, ?, [...], ** (globstar) are supported.

Runners does not support a YAML list

Another idea is to use a YAML list:

exclude_assets: 
  - '.github'
  - 'exclude file.txt'
  - 'exclude-dir/**.{md,txt}'

Unfortunately, the GitHub Actions runner does not support a YAML list in a with:.

Lucide · 2020-08-21T22:34:04Z

Good job This feature can be extremely useful for anyone who doesn't have an easy way to do out-of-source builds, I wanted to try it out but I'm encountering issues:
With publish_dir: . and exclude_assets: ".github,*.md,*.json,scss,ts" I get:

[INFO] prepare publishing assets
  [INFO] skip .git
  [INFO] copy .github
  [INFO] copy .gitignore
  [INFO] copy LICENSE
  [INFO] copy README.md
  [INFO] copy assets
  [INFO] copy build <-it's here tho. not present in the gh-pages branch
  [INFO] copy index.html
  [INFO] copy node_modules
  [INFO] copy package-lock.json
  [INFO] copy package.json
  [INFO] copy scss
  [INFO] copy ts
  [INFO] copy tsconfig.json
  [INFO] delete excluded assets
  [INFO] delete /home/runner/actions_github_pages_1598048531527/.github
  [INFO] delete /home/runner/actions_github_pages_1598048531527/README.md
  [INFO] delete /home/runner/actions_github_pages_1598048531527/package-lock.json
  [INFO] delete /home/runner/actions_github_pages_1598048531527/package.json
  [INFO] delete /home/runner/actions_github_pages_1598048531527/scss
  [INFO] delete /home/runner/actions_github_pages_1598048531527/scss/_defaults.scss
  [INFO] delete /home/runner/actions_github_pages_1598048531527/ts
  [INFO] delete /home/runner/actions_github_pages_1598048531527/ts/@types
  ##[error]Action failed with "ENOENT: no such file or directory, scandir '/home/runner/actions_github_pages_1598048531527/ts/@types'"

The error is inconsistent, it didn't occur previously, then I deleted the gh-pages branch because the action kept trying to recreate it, and now it fails regularly. I also have a build-time generated /build/ directory that gets always ignored?

peaceiris · 2020-08-22T01:43:13Z

Currently, I do not know why it fails to locate @types dir. Anyway, the following will work as a workaround.

- name: Build
  run: | 
    npm run build
    rm -rf ts

I also have a build-time generated /build/ directory that gets always ignored?

Your .gitignore has /build/. Git just follows this setting, the gh-pages branch is also a Git repository. See also #445.

Lucide · 2020-08-22T12:21:13Z

Ohh, embarrassing! must have deleted it from the list without noticing.
After fixing that, the problem above went away too

kurtbruns · 2021-05-23T21:21:41Z

First off, love the action.

However, I ran into trouble using exclude_assets for my use case. I'm trying to ignore files in the publish_dir/posts directory with the same file extension. I tried a variety of patterns, including the two below, but the files are still being committed to the gh-pages branch.

exclude_assets: "posts/**.jpg"

exclude_assets: "posts/**/*.jpg"

Workaround

The workaround I'm currently using is to create a .gitignore in the static directory that ends up in the publish directory. This seems to work fine, because when changes are committed to the gh-pages branch the files are ignored based on the pattern(s) defined the .gitignore like so:

posts/**/*.jpg

Anyways, I would love it if I could get exclude_assets working! Thanks

peaceiris · 2021-05-23T23:42:35Z

@kurtbruns Thank you for your feedback! Could you open another issue and provide more details?

pawsong added the proposal label Mar 17, 2020

pawsong assigned peaceiris Mar 17, 2020

peaceiris added the enhancement New feature or request label Mar 17, 2020

peaceiris pinned this issue Mar 17, 2020

This comment has been minimized.

Sign in to view

github-actions bot added the resolved label Apr 9, 2020

peaceiris removed the resolved label Apr 9, 2020

This comment has been minimized.

Sign in to view

Lucas-C mentioned this issue Apr 10, 2020

Petite limitation de GitHub Actions pour le déploiement en GitHub Pages covid19lejeu/covid-19-le-jeu#14

Closed

This comment has been minimized.

Sign in to view

peaceiris mentioned this issue Jul 10, 2020

Can't overwrite files on the branch with the action #390

Closed

This was referenced Jul 25, 2020

Give an option to not omit .github dir #415

Closed

feat: Add exclude_assets option #416

Merged

peaceiris added a commit that referenced this issue Jul 25, 2020

feat: Add exclude_assets option (#416)

0f5c65e

Related to #163

peaceiris pushed a commit that referenced this issue Jul 25, 2020

feat: Add exclude_assets option (#416)

41d214e

Related to #163

This comment has been minimized.

Sign in to view

peaceiris added the stale label Jul 25, 2020

peaceiris pinned this issue Jul 25, 2020

peaceiris added a commit that referenced this issue Jul 25, 2020

feat: exclude_assets supports glob patterns

32fefc5

Related to #163 https://github.com/actions/toolkit/tree/main/packages/glob

peaceiris mentioned this issue Jul 25, 2020

feat: exclude_assets supports glob patterns #417

Merged

peaceiris added a commit that referenced this issue Jul 25, 2020

feat: exclude_assets supports glob patterns (#417)

6f45501

Related to #163 https://github.com/actions/toolkit/tree/main/packages/glob

peaceiris pushed a commit that referenced this issue Jul 25, 2020

feat: exclude_assets supports glob patterns (#417)

69a302d

Related to #163 https://github.com/actions/toolkit/tree/main/packages/glob

peaceiris mentioned this issue Oct 15, 2020

Action fails when inbound and existing excluded assets differ in state #520

Closed

peaceiris closed this as completed May 23, 2021

peaceiris added the resolved label May 23, 2021

Repository owner locked as resolved and limited conversation to collaborators May 23, 2021

peaceiris unpinned this issue Jun 27, 2021

option to commit .github files #163

option to commit .github files #163

Comments

pawsong commented Mar 17, 2020 • edited Loading

peaceiris commented Mar 17, 2020 • edited Loading

pawsong commented Mar 17, 2020

pawsong commented Mar 17, 2020 • edited Loading

peaceiris commented Mar 17, 2020

peaceiris commented Mar 17, 2020 • edited Loading

pawsong commented Mar 17, 2020

pawsong commented Mar 17, 2020 • edited Loading

peaceiris commented Mar 17, 2020

pawsong commented Mar 17, 2020

Legion2 commented Mar 17, 2020

pawsong commented Mar 17, 2020

Legion2 commented Mar 17, 2020

peaceiris commented Mar 17, 2020

Legion2 commented Mar 17, 2020

pawsong commented Mar 17, 2020

Legion2 commented Mar 17, 2020

corollari commented Mar 17, 2020

peaceiris commented Mar 19, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

radames commented Jun 24, 2020

radames commented Jun 24, 2020

peaceiris commented Jun 24, 2020

This comment has been minimized.

Legion2 commented Jul 25, 2020

diauweb commented Jul 25, 2020 • edited Loading

peaceiris commented Jul 25, 2020 • edited Loading

ericleong commented Aug 11, 2020

.git

Comma-delimiting

peaceiris commented Aug 12, 2020 • edited Loading

Enhancement

Supporting a pattern **/*.{js,ts}

Runners does not support a YAML list

Lucide commented Aug 21, 2020

peaceiris commented Aug 22, 2020

Lucide commented Aug 22, 2020

kurtbruns commented May 23, 2021

Workaround

peaceiris commented May 23, 2021

pawsong commented Mar 17, 2020 •

edited

Loading

peaceiris commented Mar 17, 2020 •

edited

Loading

pawsong commented Mar 17, 2020 •

edited

Loading

peaceiris commented Mar 17, 2020 •

edited

Loading

pawsong commented Mar 17, 2020 •

edited

Loading

diauweb commented Jul 25, 2020 •

edited

Loading

peaceiris commented Jul 25, 2020 •

edited

Loading

`.git`

peaceiris commented Aug 12, 2020 •

edited

Loading

Supporting a pattern `**/*.{js,ts}`