Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Store Node ID in messages DB instead of sender short name #44

Open
Bamorph opened this issue Apr 1, 2024 · 1 comment

Comments

@Bamorph
Copy link
Contributor

Bamorph commented Apr 1, 2024

In the database i think it would be better to save the node if "!abcdef123" instead of the short name, and when we load the messages from database, we cross reference the nodeinfo to set the short name.

@pdxlocations
Copy link
Owner

Makes sense to save the node id from a database perspective. If someone changes their short name, the current model is stuck with the original name but with your approach, it would update to the new name when you load the db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants