Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading RegExp to conform to GFM/CommonMark #3

Closed
wants to merge 1 commit into from

Conversation

cribbles
Copy link

@cribbles cribbles commented Aug 28, 2018

Requires a space between the hash and the heading markup. This conforms to the CommonMark spec and is necessary for Github compatibility.

See:

Requires a space between the hash and the heading markup. This
conforms to the CommonMark spec and is necessary for Github
compatibility.

See:

- github/markup#1013 (comment)
- https://blog.github.com/2017-03-14-a-formal-spec-for-github-flavored-markdown/
@zeusdeux
Copy link

zeusdeux commented Sep 7, 2018

@pdubroy Any updates on this?

@pdubroy
Copy link
Owner

pdubroy commented Sep 9, 2018

How does the latest version of marked handle this case? From markedjs/marked#692 it looks like the new behavior is exactly what you want. If so, I'd rather update this repo to the latest version of marked, as described in the README.

@mohamedturki
Copy link

@pdubroy The latest version does not seem to solve the issue. See this.

@mohamedturki
Copy link

@pdubroy Any updates on this one? :)

@pdubroy
Copy link
Owner

pdubroy commented Nov 29, 2018

@mohamedturki The issue linked seems to indicate to me that Marked now follows the spec and requires the space. If that is true I would rather just update this package to use the latest version of Marked. This package isn't intended to be a forked version of Marked that implements slightly different behavior.

If I'm wrong and Marked doesn't behave in the way this issue is describing, please post some console output and/or a gist demonstrating that — I'd like to be sure.

Thanks.

@cribbles cribbles closed this Mar 19, 2021
@cribbles cribbles deleted the GFH-heading-fix branch March 19, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants