Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash in issuer #22

Closed
michielbdejong opened this issue Oct 19, 2020 · 2 comments
Closed

Trailing slash in issuer #22

michielbdejong opened this issue Oct 19, 2020 · 2 comments
Milestone

Comments

@michielbdejong
Copy link
Member

See https://travis-ci.com/github/pdsinterop/php-solid-server/builds/190957568#L2133
It should not have a trailing slash there.
See also 3299c4e

@Potherca
Copy link
Member

I encountered the same issue, have a fix pending. Ideally this bug will go away when we replace the hard-coded bit with dynamic host-name retrieval.

@Potherca Potherca added this to the v0.4.0 milestone Oct 23, 2020
@Potherca
Copy link
Member

A first solution has been implemented in 9b2c3e0 by retrieving the domain form $_SERVER['REQUEST_URI'], this can later be replaced by a config setting if/when needed.

Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants