Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: minor positioner ui tweaks #1244

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jun 12, 2024

Description

  • Replace the "disabled" broken setpoint widget with a simple bitmask clicker
  • Tweak the positioner layouts to enable them to be expandable

Motivation and Context

The other option that sort of worked for the disabled widget was simple text entry but:

  • This had the unit attached (0mm is off, 1mm is on...)
  • It was awkward to know to type 0 or 1

I couldn't get typhos to assign a custom enum combobox to this widget. There was an option to have two vertical buttons to click but I didn't like it.

How Has This Been Tested?

Interactively only

Where Has This Been Documented?

Here only, I need to make pre-release notes

Screenshots (if appropriate):

Old "disabled" widget (completely inoperable):
image

New "disabled" widget:
image

New widget when disabled (click the right-hand bitmask widget to toggle):
image

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@ZLLentz ZLLentz marked this pull request as ready for review June 27, 2024 20:41
@ZLLentz ZLLentz requested a review from tangkong June 27, 2024 20:41
@tangkong
Copy link
Contributor

Needs another merge commit, but aside from that I'm 👍 on this

@ZLLentz ZLLentz merged commit f929fa0 into pcdshub:master Jun 27, 2024
11 checks passed
@ZLLentz ZLLentz deleted the maint_minor_ui branch June 27, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants