Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwinCAT PLC/library PRs without source code changes failing #110

Open
klauer opened this issue Mar 7, 2023 · 0 comments
Open

TwinCAT PLC/library PRs without source code changes failing #110

klauer opened this issue Mar 7, 2023 · 0 comments

Comments

@klauer
Copy link
Contributor

klauer commented Mar 7, 2023

Issue

Intended to resolve in #108 but failed in a misguided attempt

Here's the issue:
https://github.com/pcdshub/lcls-plc-tmo-optics/actions/runs/4348701131/jobs/7597534512

The first step lists files that were changed (e.g., *.tmc or *.cmd) but the filter step (looking for TcPOU/TcGVL to check) finds nothing from that list.

The fix

The fix needs to come in the filter step - if grep fails to find anything, we revert back to the entire list of project files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant