Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize Redundant Deprecation Warnings #170

Closed
ZLLentz opened this issue Jul 14, 2023 · 0 comments · Fixed by #183
Closed

Minimize Redundant Deprecation Warnings #170

ZLLentz opened this issue Jul 14, 2023 · 0 comments · Fixed by #183

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Jul 14, 2023

Current Behavior

Some of the deprecated function blocks show many many deprecation warnings, since they themselves reference deprecated names.

Expected Behavior

There should only be 1 warning per deprecation infraction, rather than potentially dozens.

Context / environment

PR review at #163 (comment)

In the context of the demo PLC, this ends up producing a lot of deprecation warnings. You'd naively only expect 2 warnings (using DUT_MotionStage once + using XPIM which extends a deprecated FB) but you get many more. I think some of this is due to deprecated FBs including deprecated FBs and deprecated structs and getting the compiler warning in every layer.

Suggested Solution

We should switch out all internal names, even those in deprecated function blocks, to use the newest names when there is a 1:1 alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant