Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: disabling serverstat off and cycle for drp nodes #181

Merged
merged 4 commits into from
May 16, 2024

Conversation

KaushikMalapati
Copy link
Contributor

Description

Trying to turn off or power cycle a drp node (a server with drp in its hostname) will instead point you to a confluence page explaining how to do this through the ipmi web interface and exit because using serverStat/psipmi sometimes causes the ipmi interfaces to stop working until they are manually restarted whereas the web interface works as exptected.

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-5126

How Has This Been Tested?

Interactively

Where Has This Been Documented?

Code will print out a message, but I did not update the serverStat readme description because I thought this would be too specific to mention.

@KaushikMalapati KaushikMalapati requested review from ZryletTC and silkenelson and removed request for ZryletTC April 22, 2024 21:52
scripts/serverStat Outdated Show resolved Hide resolved
ZLLentz
ZLLentz previously approved these changes Apr 23, 2024
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran as myself to confirm working:

zlentz@psbuild-rhel7-01:~/.../engineering_tools/scripts(serverStat -)$ ./serverStat drp-fake-machine off
The off and cycle serverStat commands are unavailable on DRP nodes. Do not use psipmi power off or psipmi power cycle directly on DRP nodes as this will disable the ipmi card. Instead, use the web interface as described on:

https://confluence.slac.stanford.edu/display/PSDMInternal/Debugging+DAQ#DebuggingDAQ-IPMI

ZLLentz
ZLLentz previously approved these changes Apr 23, 2024
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 with this, maybe @silkenelson has more specific requests for the verbiage.

@silkenelson
Copy link
Collaborator

Please hold this. I thought I had added a comment here yesterday with the exact verbiage I wanted which I assume I now have to remember what it was.

@KaushikMalapati
Copy link
Contributor Author

@ZLLentz, could you approve this again? I just changed the exit message.

@@ -137,6 +137,11 @@ if [[ $NAME == *rec* ]]; then
fi
fi

if [[ "${NAME,,}" == *drp* ]] && ([[ $CMD == "off" ]] || [[ $CMD == "cycle" ]]); then
printf "serverStat $CMD is not supported on the DRP nodes as the underlying psipmi power off or psipmi power cycle commands will disable the ipmi card. Instead, use the web interface as described on:\n\nhttps://confluence.slac.stanford.edu/display/PSDMInternal/Debugging+DAQ#DebuggingDAQ-IPMI\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to repost Silke's last comment as a suggestion because her messages seem to be getting buried- maybe as a result of how Github processes email replies?

I apparently can't English....can you change the beginning to:
serverStat $CMD is not supported for DRP nodes

Suggested change
printf "serverStat $CMD is not supported on the DRP nodes as the underlying psipmi power off or psipmi power cycle commands will disable the ipmi card. Instead, use the web interface as described on:\n\nhttps://confluence.slac.stanford.edu/display/PSDMInternal/Debugging+DAQ#DebuggingDAQ-IPMI\n"
printf "serverStat $CMD is not supported for DRP nodes as the underlying psipmi power off or psipmi power cycle commands will disable the ipmi card. Instead, use the web interface as described on:\n\nhttps://confluence.slac.stanford.edu/display/PSDMInternal/Debugging+DAQ#DebuggingDAQ-IPMI\n"

1333e8d#comments

I think with her last request in I will re-approve and we can merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely missed this. How can I see this comment without your hyperlink?

Co-authored-by: Zachary Lentz <[email protected]>
@ZLLentz
Copy link
Member

ZLLentz commented May 16, 2024

shellcheck is upset but hopefully your other PR handles the issues related to that, so let's merge this as-is!

@ZLLentz ZLLentz merged commit 3f52634 into pcdshub:master May 16, 2024
1 of 2 checks passed
@KaushikMalapati KaushikMalapati deleted the serverStat branch September 28, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants