fix(set_gem_timing): updated logic to reflect application layer concers: do not exit the program if PV and IOC software are out of sync #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshc-slac
force-pushed
the
joshc-slac/fix_set_gem_timing
branch
from
59c3fb3 to
f0896e5
Compare
…rs: do not exit the program if PV and IOC software are out of sync
joshc-slac
force-pushed
the
joshc-slac/fix_set_gem_timing
branch
from
f0896e5 to
3315d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the valid concern in the set_gem_timing script that we want to guard against the edge case where PV:
KFE:CAM:TPR:02:MODEis inconsistent with IOC software path.For reference here is the intended pairing:
ioc/fee/GasDetDAQ/R4.0.22-NOTSioc/fee/GasDetDAQ/R4.0.22Critical functional change is that if an operator tries to run
set_gem_timinginto a mode in which the PV:KFE:CAM:TPR:02:MODEalready is in it will not terminate the program.Motivation and Context
#163 (comment)
How Has This Been Tested?
Where Has This Been Documented?
Code comment and output of command